Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup test workflow for various OSs #40

Merged
merged 35 commits into from
May 2, 2024

Conversation

manuGil
Copy link
Collaborator

@manuGil manuGil commented Mar 18, 2024

This is an initial workflow for testing the installation instructions in various Os. Later today we will continue with #33

@manuGil manuGil added the help wanted Looking for Contributors label Mar 18, 2024
@manuGil manuGil self-assigned this Mar 18, 2024
Copy link

github-actions bot commented Mar 18, 2024

ℹ️ Modified Workflows

This pull request contains modified workflow files and no preview will be created.

Workflow files modified:

  • .github/workflows/workshop-setup.yml

If this is not from a trusted source, please inspect the changes for any malicious content.

@cforgaci
Copy link
Collaborator

cforgaci commented Mar 18, 2024

Thanks @manuGil and @Selkubi for starting to work on this! I did not have time to look into this yet, but I would start assembling the configuration for this by looking at r-lib/actions and the workflows used by our repository.

@manuGil manuGil marked this pull request as draft March 18, 2024 18:37
@manuGil manuGil marked this pull request as ready for review March 18, 2024 22:12
@manuGil
Copy link
Collaborator Author

manuGil commented Mar 18, 2024

I added the installations steps from the lessons. However, the windows job keeps failing
@Selkubi could you please keep debugging this workflow?

The windows job fails because of the R version (strange enough, it worked the very first time). The job fails in step:

Run r-lib/actions/setup-r@v2
D:\a\_temp\R-4.3.3-win.exe /VERYSILENT /SUPPRESSMSGBOXES /DIR=C:\R
Downloading https://cran.rstudio.com/bin/windows/Rtools/Rtools4.3.x.exe...
Error: Failed to get R 4.3.3: Failed to get R 4.3.3: Failed to download version [object Object]: Error: Unexpected HTTP response: 404

@cforgaci
Copy link
Collaborator

@manuGil, nice! That is a 404 response, so the link does not seem to be correct. Does this work instead? https://cran.r-project.org/bin/windows/Rtools/rtools43/files/rtools43-5958-5975.exe

@manuGil
Copy link
Collaborator Author

manuGil commented Mar 19, 2024

@manuGil, nice! That is a 404 response, so the link does not seem to be correct. Does this work instead? https://cran.r-project.org/bin/windows/Rtools/rtools43/files/rtools43-5958-5975.exe

@cforgaci The link is being provided by an action from https://github.com/r-lib/actions/tree/v2-branch/setup-r The only part that I changed was the R version the workflow uses. So I guess is an issue with their action because it works for the other OSs... Or it could be that for windows it is different. Maybe the following can give us an insight on what the problem is:

  • Check if the job work when using only windows,
  • Check if the job works when no version of R specified, or pointed to the latest available (which might be different for different OS)

@Selkubi
Copy link
Collaborator

Selkubi commented Mar 20, 2024

@manuGil I have tried in my fork

  1. only windows
  2. no version line at all
  3. older version
    and got the same error
    D:\a\_temp\R-4.3.3-win.exe /VERYSILENT /SUPPRESSMSGBOXES /DIR=C:\R Downloading https://cran.rstudio.com/bin/windows/Rtools/Rtools4.3.x.exe... Error: Failed to get R 4.3.3: Failed to get R 4.3.3: Failed to download version [object Object]: Error: Unexpected HTTP response: 404

@Selkubi
Copy link
Collaborator

Selkubi commented Mar 20, 2024

Also, when I directly copy the matrix testing and change the R version the test runs smoothly and when I add the os os: [ubuntu-latest, windows-latest, macos-latest then it passes the first part and gives an error with the GDAL, GEOS, PROJ4 like so
So I would assume our R version works fine.

@manuGil
Copy link
Collaborator Author

manuGil commented Mar 20, 2024

@cforgaci and @Selkubi Thanks for trying things out. I will go back to it on Friday.

@manuGil
Copy link
Collaborator Author

manuGil commented Mar 23, 2024

I fixed the issue with Windows. The name for the version of RTools was wrongly written (it should be 43 and not the usual 4.3 as I assumed.

The issue with MacOS is partially solved. I made progress with most of the errors with brew link, but not all. It seems to be a conflict between Python versions. The latest MacOs version in Github is Monterey, not Sonoma and that might have something to do with it (not sure).
@cforgaci could you please check if the instruction to install the packages in step Install GDAL, GEOS, and PROJ.4 (macOS) are correct for Monterey?

Trace back: https://github.com/manuGil/r-geospatial-urban/actions/runs/8401072439/job/23009071352

@manuGil
Copy link
Collaborator Author

manuGil commented Apr 2, 2024

Somona is now available for runners as latest version for MacOS

@manuGil
Copy link
Collaborator Author

manuGil commented Apr 25, 2024

I fixed the issue with Windows. The name for the version of RTools was wrongly written (it should be 43 and not the usual 4.3 as I assumed.

The issue with MacOS is partially solved. I made progress with most of the errors with brew link, but not all. It seems to be a conflict between Python versions. The latest MacOs version in Github is Monterey, not Sonoma and that might have something to do with it (not sure). @cforgaci could you please check if the instruction to install the packages in step Install GDAL, GEOS, and PROJ.4 (macOS) are correct for Monterey?

Trace back: https://github.com/manuGil/r-geospatial-urban/actions/runs/8401072439/job/23009071352

Check if installing XCode solves this issue

Copy link
Collaborator

@cforgaci cforgaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @manuGil for this! I suggested an R script to test sf and tidyverse in my last comment.

sudo apt-get update
sudo apt-get install libgdal-dev libgeos-dev libproj-dev -y
shell: bash
# Include Fedora and Arch?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I would add those too.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I will add those in the next revision. I opened this issue #45 for that. For now, I suggest we complete the merge for the current tests.

.github/workflows/workshop-setup.yml Outdated Show resolved Hide resolved
@manuGil manuGil changed the title Scafolding setup workflow using various OSs Setup workflow CI using various OSs May 2, 2024
@manuGil manuGil changed the title Setup workflow CI using various OSs Setup test workflow for various OSs May 2, 2024
@manuGil
Copy link
Collaborator Author

manuGil commented May 2, 2024

@cforgaci and @Selkubi, the workflow is working now and the tests provide by Claudiu were included. We can merge this PR.

@cforgaci
Copy link
Collaborator

cforgaci commented May 2, 2024

Excellent. Thanks, @manuGil! I will merge the PR.

@cforgaci cforgaci merged commit 60bd8aa into carpentries-incubator:main May 2, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request May 2, 2024
Auto-generated via {sandpaper}
Source  : 60bd8aa
Branch  : main
Author  : Claudiu Forgaci <[email protected]>
Time    : 2024-05-02 18:37:44 +0000
Message : Merge pull request #40 from manuGil/main
github-actions bot pushed a commit that referenced this pull request May 2, 2024
Auto-generated via {sandpaper}
Source  : 1cd1252
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-05-02 18:43:23 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 60bd8aa
Branch  : main
Author  : Claudiu Forgaci <[email protected]>
Time    : 2024-05-02 18:37:44 +0000
Message : Merge pull request #40 from manuGil/main
github-actions bot pushed a commit that referenced this pull request May 7, 2024
Auto-generated via {sandpaper}
Source  : 60bd8aa
Branch  : main
Author  : Claudiu Forgaci <[email protected]>
Time    : 2024-05-02 18:37:44 +0000
Message : Merge pull request #40 from manuGil/main
github-actions bot pushed a commit that referenced this pull request May 7, 2024
Auto-generated via {sandpaper}
Source  : c686ae1
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-05-07 00:42:16 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 60bd8aa
Branch  : main
Author  : Claudiu Forgaci <[email protected]>
Time    : 2024-05-02 18:37:44 +0000
Message : Merge pull request #40 from manuGil/main
github-actions bot pushed a commit that referenced this pull request May 14, 2024
Auto-generated via {sandpaper}
Source  : 60bd8aa
Branch  : main
Author  : Claudiu Forgaci <[email protected]>
Time    : 2024-05-02 18:37:44 +0000
Message : Merge pull request #40 from manuGil/main
github-actions bot pushed a commit that referenced this pull request May 14, 2024
Auto-generated via {sandpaper}
Source  : b47841e
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-05-14 00:39:39 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 60bd8aa
Branch  : main
Author  : Claudiu Forgaci <[email protected]>
Time    : 2024-05-02 18:37:44 +0000
Message : Merge pull request #40 from manuGil/main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Looking for Contributors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants